Re: [PATCH v33 0/5] Add ASPEED AST2600 I2C controller driver

From: andriy.shevchenko@xxxxxxxxxxxxxxx

Date: Wed Nov 18 2026 - 05:30:51 EST


On Wed, Nov 18, 2026 at 08:53:36AM +0000, Ryan Chen wrote:
> > On Wed, Nov 18, 2026 at 08:14:51AM +0000, Ryan Chen wrote:
> > >
> > > This patch series has been stable in our testing on AST2600 hardware,
> > > and we have also received positive feedback from customer testing.
> > > The issues identified by Sashiko have also been addressed.
> > > I plan to rebase the series onto the latest upstream kernel and submit v34.
> > > Before doing so, I would appreciate your feedback on whether there are
> > > any remaining concerns or blockers that we should address.
> > >
> > > If there are no outstanding issues, I hope the series can be
> > > considered for merging after the next review.
> > >
> > > Thanks for your time and support.
> >
> > Are you asking me or Andi Shyti?
> > If it was to me, I have no time for this right now, sorry.
>
> Thanks for your response.
> Would you happen to know anyone else who might have time to review it?

Not of my knowledge. The general practice is to help maintainers to review
their queue(s) and in response somebody else hopefully reviews yours. If you
completely rely on maintainer to allocate a time to review your stuff, you
might wait for months these days (mostly because tons of AI slops attacking
the LKML). I might be mistaken, but I haven't seen match of @aspeedtech.com
in the Reviewed-by: tags. Probably that's what you should do better?

That's what I got for the entire history of Linux kernel

$ git log --no-merges --oneline --grep 'Reviewed-by:.*@aspeedtech.com'

51d0f5020dee crypto: aspeed - Use memcpy_from_sglist() in aspeed_ahash_dma_prepare()
dba7567c2fbb usb: gadget: aspeed_udc: fix device address configuration
aba59ce109de peci: aspeed: Clear clock_divider value before setting it
4dc44aec28c8 crypto: aspeed-hace - Use device_get_match_data()
9ee8fbc05ef0 spi: aspeed: Use helper function devm_clk_get_enabled()
eb33108858b6 crypto: aspeed - Fix modular aspeed-acry
7484a5bc153e drm/ast: Fix start address computation
aaf16cdca641 crypto: aspeed - change aspeed_acry_akcipher_algs to static
f104b2169e68 crypto: aspeed - Replace zero-length array with flexible-array member
83045e19feae usb: gadget: aspeed: fix buffer overflow
70513e1d6559 crypto: aspeed - Fix check for platform_get_irq() errors
dc377e013bec crypto: aspeed - fix return value check in aspeed_hace_probe()
efc96d43ec38 crypto: aspeed - Fix sparse warnings
31b39755e325 crypto: aspeed - Enable compile testing
9deb10cf160e ARM: dts: aspeed: ast2600-evb: Update I2C devices
70cdb930f7e9 usb: gadget: aspeed_udc: fix handling of tx_len == 0
3d393f0303b5 usb: gadget: aspeed_udc: fix missing spin_unlock_irqrestore in ast_udc_ep_queue
6fd45e79e8b9 net: ftgmac100: Disable hardware checksum on AST2600
fea289467608 ARM: dts: aspeed: Add secure boot controller node
8812dff6459d soc: aspeed: socinfo: Add AST2625 variant
d0ec795c8c27 ipmi: kcs_bmc_aspeed: Optionally apply status address

But even them are "aspeed" cases, so you looked at the code written inside your
company which does NOT count as help to the maintainers with their queues
(okay, it counts, but with low priority as these are not 3rd party reviews).


> > > > This series adds support for the AST2600 I2C controller “new register set”
> > > > implementation.
> > > >
> > > > The AST2600 I2C controller introduces a revised register layout
> > > > which separates controller and target functionality into distinct
> > > > register blocks, and extends clock divider configuration and
> > > > packet-based transfer support compared to the legacy mixed register
> > layout used on earlier ASPEED SoCs.
> > > >
> > > > The current driver implementation for the AST2600 I2C peripheral is
> > > > through the hardware's "compatibility mode", which exposes a
> > > > register set that matches the previous generation hardware (AST2500 and
> > earlier).
> > > >
> > > > Instead, add a driver that works in new-register-set mode, to allow
> > > > the new features, and will provide support for future hardware that
> > > > will not implement compatibility mode.
> > > >
> > > > In order to support the new mode, we need a DT binding change to
> > > > reflect the reference to the global register set. Since the binding
> > > > still represents the same
> > > > (AST2600 SoC) physical hardware, we continue to use the existing
> > > > compatible string of "aspeed,ast2600-i2c-bus".
> > > >
> > > > However: since we're changing semantics for an existing binding, we
> > > > allow backwards compatibility by selecting on presence/absence of
> > > > the newly-added properties, and fall back to the old driver (ie., in
> > > > compatibility mode) when we detect a DT using the old binding spec.
> > > >
> > > > Specifically:
> > > >
> > > > - ast2600-i2c-bus nodes that provide the `aspeed,global-regs` property
> > > > (present in the new binding and absent in the legacy binding) will be
> > > > successfully probed by the new driver
> > > >
> > > > - ast2600-i2c-bus nodes without `aspeed,global-regs` continue to use the
> > > > existing driver (in legacy register mode), ensuring that platforms
> > > > with the current DTBs remain functional

--
With Best Regards,
Andy Shevchenko