RE: [PATCH v33 0/5] Add ASPEED AST2600 I2C controller driver
From: Ryan Chen
Date: Wed Nov 18 2026 - 03:53:45 EST
> Subject: Re: [PATCH v33 0/5] Add ASPEED AST2600 I2C controller driver
>
> On Wed, Nov 18, 2026 at 08:14:51AM +0000, Ryan Chen wrote:
> > Hi Andy,
> >
> > This patch series has been stable in our testing on AST2600 hardware,
> > and we have also received positive feedback from customer testing.
> > The issues identified by Sashiko have also been addressed.
> > I plan to rebase the series onto the latest upstream kernel and submit v34.
> > Before doing so, I would appreciate your feedback on whether there are
> > any remaining concerns or blockers that we should address.
> >
> > If there are no outstanding issues, I hope the series can be
> > considered for merging after the next review.
> >
> > Thanks for your time and support.
>
> Are you asking me or Andi Shyti?
> If it was to me, I have no time for this right now, sorry.
Thanks for your response.
Would you happen to know anyone else who might have time to review it?
Best regards,
Ryan
>
> > > Subject: [PATCH v33 0/5] Add ASPEED AST2600 I2C controller driver
> > >
> > > This series adds support for the AST2600 I2C controller “new register set”
> > > implementation.
> > >
> > > The AST2600 I2C controller introduces a revised register layout
> > > which separates controller and target functionality into distinct
> > > register blocks, and extends clock divider configuration and
> > > packet-based transfer support compared to the legacy mixed register
> layout used on earlier ASPEED SoCs.
> > >
> > > The current driver implementation for the AST2600 I2C peripheral is
> > > through the hardware's "compatibility mode", which exposes a
> > > register set that matches the previous generation hardware (AST2500 and
> earlier).
> > >
> > > Instead, add a driver that works in new-register-set mode, to allow
> > > the new features, and will provide support for future hardware that
> > > will not implement compatibility mode.
> > >
> > > In order to support the new mode, we need a DT binding change to
> > > reflect the reference to the global register set. Since the binding
> > > still represents the same
> > > (AST2600 SoC) physical hardware, we continue to use the existing
> > > compatible string of "aspeed,ast2600-i2c-bus".
> > >
> > > However: since we're changing semantics for an existing binding, we
> > > allow backwards compatibility by selecting on presence/absence of
> > > the newly-added properties, and fall back to the old driver (ie., in
> > > compatibility mode) when we detect a DT using the old binding spec.
> > >
> > > Specifically:
> > >
> > > - ast2600-i2c-bus nodes that provide the `aspeed,global-regs` property
> > > (present in the new binding and absent in the legacy binding) will be
> > > successfully probed by the new driver
> > >
> > > - ast2600-i2c-bus nodes without `aspeed,global-regs` continue to use the
> > > existing driver (in legacy register mode), ensuring that platforms
> > > with the current DTBs remain functional
>
> --
> With Best Regards,
> Andy Shevchenko
>