Re: [PATCH v4] platform/x86: asus-wmi: fix camera key LED on Zenbook S14
From: Devin Bayer
Date: Wed Nov 18 2026 - 04:02:48 EST
On 17/11/2026 14.52, Rong Zhang wrote:
When a device has both ASUS_WMI_DEVID_CAMERA_LED and
ASUS_WMI_DEVID_CAMERA_LED_NEG implemented, camera_neg_led_available is
false and the LED device can't benefit from brightness_hw_changed.
Does such device even exists? Can it exists?
(+CC Devin)
Both macros were added together, i.e., in commit 4bf1ea3fc914
("platform/x86: asus-wmi: support the disable camera LED on F10 of
Zenbook 2023") for Zenbook UX3404VC, so I assume it has both implemented.
Plus, the name "_NEG" sounds like it was concluded through trial-and-
error.
I suspect that the two devids were defined for different purposes, i.e.,
0x00060078 for notification and 0x00060079 for query.
Hello Rong,
I can tell you what I know. I discovered the arguments from the ACPI metadata, and found that writing to both the CAMERA and CAMERA_NEG does the same thing, as far as I know, but NEG 1 = other 0.
They control the LED and the camera.
I don't know about query and notifications.
The hardware key doesn't do anything if it's remapped, at least in my setup.
So it has both, I don't know which is more correct. I just documented it for posterity.It'd be better to decouple the brightness_hw_changed path from
!ASUS_WMI_DEVID_CAMERA_LED, since devices with both IDs should be able to
emit the WMI event.
With that, how about adding a wrapper function that dispatches call to
either asus_wmi_get_devstate(ASUS_WMI_DEVID_CAMERA_LED) or
asus_wmi_get_devstate(ASUS_WMI_DEVID_CAMERA_LED_NEG) according to the
IDs' presence? Then you can share the same brightness_hw_changed path by
calling the wrapper function and eliminate the need of adding a dedicated
brightness_get() callback in the same manner.
I'm not understanding this: first the discussion moves toward "what if one
device has both" and then you ask about reusing the code for the non-neg
dev id.... What am I missing here?
Because I assume such devices exist. Perhaps Devin can give us some
clues...
Cheers,
Devin