Re: [PATCH v7 3/5] iommu/of: Make OF_IOMMU depend on OF_ADDRESS
From: Dmitry Baryshkov
Date: Wed Nov 18 2026 - 04:02:32 EST
On Thu, Nov 12, 2026 at 07:10:38PM +0530, Vikash Garodia wrote:
>
> On 11/11/2026 6:33 PM, Dmitry Baryshkov wrote:
> > On Fri, Nov 06, 2026 at 10:44:26PM +0530, Vikash Garodia wrote:
> > > The OF_IOMMU code relies on OF address parsing helpers, but the
> > > dependency on OF_ADDRESS is not expressed in Kconfig. As a result,
> > > of_iommu.c contains CONFIG_OF_ADDRESS guards and a __maybe_unused
> > > annotation to handle configurations where OF_ADDRESS is disabled.
> > >
> > > Make OF_IOMMU depend on OF_ADDRESS and remove the now unnecessary
> > > preprocessor guards and __maybe_unused annotation.
> >
> > Why? What's the problem that you are solving? Why is the current code
> > bad?
> >
>
> The commit describes the problem as "The OF_IOMMU code relies on OF address
> parsing helpers, but the dependency on OF_ADDRESS is not expressed in
> Kconfig"...and instead the code had checks for config or __maybe_unused for
> cases like sparc.
What is wrong with this approach? What is the problem? There is one, but
please state it in the commit message. Something is wrong, otherwise you
wouldn't be fixing it.
>
> It was discussed in prior rev
> https://lore.kernel.org/all/20261104160346.GD3951195-robh@xxxxxxxxxx/
That's fine, but the reason must be capturedd
>
> Regards,
> Vikash
> > >
> > > The only architecture supporting OF without OF_ADDRESS is SPARC, which
> > > does not use OF_IOMMU, so no functional change is intended.
> > >
> > > Suggested-by: Rob Herring <robh@xxxxxxxxxx>
> > > Co-developed-by: Vishnu Reddy <busanna.reddy@xxxxxxxxxxxxxxxx>
> > > Signed-off-by: Vishnu Reddy <busanna.reddy@xxxxxxxxxxxxxxxx>
> > > Signed-off-by: Vikash Garodia <vikash.garodia@xxxxxxxxxxxxxxxx>
> > > ---
> > > drivers/iommu/Kconfig | 2 +-
> > > drivers/iommu/of_iommu.c | 4 +---
> > > 2 files changed, 2 insertions(+), 4 deletions(-)
> > >
> >
>
--
With best wishes
Dmitry