[PATCH v3 2/2] blk-throttle: kill the no longer needed overflow check in calculate_bytes_allowed()
From: Oleg Nesterov
Date: Fri Aug 15 2025 - 12:48:47 EST
Now that mul_u64_u64_div_u64() can't crash there is no need to check for
possible overflow in calculate_bytes_allowed().
Signed-off-by: Oleg Nesterov <oleg@xxxxxxxxxx>
---
block/blk-throttle.c | 6 ------
1 file changed, 6 deletions(-)
diff --git a/block/blk-throttle.c b/block/blk-throttle.c
index 397b6a410f9e..66339e22cc85 100644
--- a/block/blk-throttle.c
+++ b/block/blk-throttle.c
@@ -601,12 +601,6 @@ static unsigned int calculate_io_allowed(u32 iops_limit,
static u64 calculate_bytes_allowed(u64 bps_limit, unsigned long jiffy_elapsed)
{
- /*
- * Can result be wider than 64 bits?
- * We check against 62, not 64, due to ilog2 truncation.
- */
- if (ilog2(bps_limit) + ilog2(jiffy_elapsed) - ilog2(HZ) > 62)
- return U64_MAX;
return mul_u64_u64_div_u64(bps_limit, (u64)jiffy_elapsed, (u64)HZ);
}
--
2.25.1.362.g51ebf55