Re: [PATCH v8 3/6] rust: irq: add support for non-threaded IRQs and handlers

[Daniel Almeida]

> On 11 Aug 2025, at 09:43, Alice Ryhl <aliceryhl@xxxxxxxxxx> wrote:
> 
> On Mon, Aug 11, 2025 at 2:38 PM Daniel Almeida
> <daniel.almeida@xxxxxxxxxxxxx> wrote:
>> 
>> 
>>>> Also, I was getting tons of “unreachable_pub” warnings
>>>> otherwise, FYI.
>>> 
>>> If you got unreachable_pub warnings, then you are missing re-exports.
>>> 
>>> Alice
>> 
>> The re-exports are as-is in the current patch, did I miss anything? Because I
>> don’t think so.
>> 
>> In particular, should the irq module itself be private?
> 
> No, the end-user should be able to write
> 
>    use kernel::irq::Flags;
> 
> so the irq module needs to be public.
> 
> Alice

Ah, maybe this is the issue then, i.e [0]:

```
(This requires a re-export in the irq module if you don't have one
already. Also, I would make the irq module private so that end-users
import everything via the irq:: path without a sub-module.)
```

Fine, let me try this again.

— Daniel

[0]: https://lore.kernel.org/all/aH5TMzJGqzg3wNjK@xxxxxxxxxx/