Re: [PATCH v8 3/6] rust: irq: add support for non-threaded IRQs and handlers
From: Alice Ryhl
Date: Mon Aug 11 2025 - 08:43:37 EST
On Mon, Aug 11, 2025 at 2:38 PM Daniel Almeida
<daniel.almeida@xxxxxxxxxxxxx> wrote:
>
>
> >> Also, I was getting tons of “unreachable_pub” warnings
> >> otherwise, FYI.
> >
> > If you got unreachable_pub warnings, then you are missing re-exports.
> >
> > Alice
>
> The re-exports are as-is in the current patch, did I miss anything? Because I
> don’t think so.
>
> In particular, should the irq module itself be private?
No, the end-user should be able to write
use kernel::irq::Flags;
so the irq module needs to be public.
Alice