Re: [PATCH net] net: mdio_bus: Use devm for getting reset GPIO

From: Jakub Kicinski
Date: Wed Jul 30 2025 - 21:16:59 EST


On Mon, 28 Jul 2025 17:34:55 +0200 Bence Csókás wrote:
> Commit bafbdd527d56 ("phylib: Add device reset GPIO support") removed
> devm_gpiod_get_optional() in favor of the non-devres managed
> fwnode_get_named_gpiod(). When it was kind-of reverted by commit
> 40ba6a12a548 ("net: mdio: switch to using gpiod_get_optional()"), the devm
> functionality was not reinstated. Nor was the GPIO unclaimed on device
> remove. This leads to the GPIO being claimed indefinitely, even when the
> device and/or the driver gets removed.
>
> Fixes: bafbdd527d56 ("phylib: Add device reset GPIO support")
> Fixes: 40ba6a12a548 ("net: mdio: switch to using gpiod_get_optional()")
> Cc: Csaba Buday <buday.csaba@xxxxxxxxx>
> Signed-off-by: Bence Csókás <csokas.bence@xxxxxxxxx>

Looks like this is a v2 / rewrite of
https://lore.kernel.org/all/20250709133222.48802-3-buday.csaba@xxxxxxxxx/
? Please try to include more of a change log / history of the changes
(under the --- marker)

Andrew, you acked what I'm guessing was the v1, still looks good?