Re: [PATCH] ASoC: amd: acp: Adjust pdm dmic gain using module parameter

From: Mark Brown
Date: Tue Jul 29 2025 - 06:36:28 EST


On Tue, Jul 29, 2025 at 11:34:59AM +0530, Mario Limonciello wrote:
> On 7/28/2025 4:22 PM, Greg KH wrote:
> > On Mon, Jul 28, 2025 at 03:12:27PM +0530, Venkata Prasad Potturu wrote:

> > > * If users do end up using it to debug and report different values
> > > we should introduce a config knob that can have policy set by ucm.

> > Please do this properly, with a per-device setting.

> As the main purpose for this parameter is for being able to tune whether the
> property is correct, how about adding a debugfs file instead?

> AFAICT it should just be a single register write, so debugfs to read current
> value and write the debugging value seems pretty straightforward.

Or you could just go direct to making it user tunable like a normal gain
control?

Attachment: signature.asc
Description: PGP signature