Re: [PATCH] ASoC: amd: acp: Adjust pdm dmic gain using module parameter

From: Greg KH
Date: Mon Jul 28 2025 - 06:52:53 EST


On Mon, Jul 28, 2025 at 03:12:27PM +0530, Venkata Prasad Potturu wrote:
> Adjust pdm dimc gain value using module param.
> In case of regressions for any users that the new pdm_gain value is
> too high and for additional debugging, introduce a module parameter
> that would let them configure it.
>
> This parameter should be removed in the future:
> * If it's determined that the parameter is not needed, just hardcode
> the correct value as before
> * If users do end up using it to debug and report different values
> we should introduce a config knob that can have policy set by ucm.

Note, you can not break a user/kernel api like this once you introduce
it, so be VERY careful (yet another reason for it to NOT be a module
parameter...)