Re: [PATCH v4] ALSA: usb-audio: qcom: Adjust mutex unlock order

[Markus Elfring]

…
> > +++ b/sound/usb/qcom/qc_audio_offload.c
…
> > @@ -1865,8 +1865,8 @@ static void qc_usb_audio_offload_disconnect(struct snd_usb_audio *chip)
> >  
> >  	/* Device has already been cleaned up, or never populated */
> >  	if (!dev->chip) {
> > -		mutex_unlock(&qdev_mutex);
> >  		mutex_unlock(&chip->mutex);
> > +		mutex_unlock(&qdev_mutex);
> >  		return;
> >  	}
> >  
…
> In anyway, I applied the patch now.

How do you think about to refine this function implementation another bit
by using an additional label like “unlock” rather than keeping duplicate
source code?


Regards,
Markus