Re: [PATCH v4 2/2] nvme: prevent admin controller from smart log fetch (LID 2)

[Kamaljit Singh]

Hi Christoph,

From: Christoph Hellwig <hch@xxxxxx>
Date: Monday, July 21, 2025 at 23:30
>> Similar to a discovery ctrl, prevent an admin-ctrl from getting a smart
>> log. LID 2 is optional for admin controllers to support.
>>
>> In the future when support for the newly added LID=0 (supported log
>> pages) is added, GLP accesses can be made smarter by basing such calls
>> on response from LID=0 reads.

>Umm, as pointed out last time, this log page is prohibited for discovery
>controllers, but optional for admin controllers.  So I don't see why
>we want or need to skip it here.
Sorry, looks I may have misunderstood your last comment from v2 (pasted below).
By "let's leave this in", I thought you were referring to my patch. But now that I re-read
it, seems like by "failing a get_log page is fine" you probably meant to let the driver 
issue a get_log for LID=2 and fail.

Process wise, can you ignore this 2/2 patch and we call this patch-set done?
 
>From: Christoph Hellwig hch@xxxxxx
>Date: Thursday, July 3, 2025 at 02:05
>Subject: Re: [PATCH v2 2/3] nvme: prevent admin controller from smart log fetch (LID 2)
>> Similar to a discovery ctrl, prevent an admin-ctrl from getting a smart
>> log. LID 2 is optional for admin controllers to support.
>>
>> In the future when support for the newly added LID=0 (supported log
>> pages) is added, GLP accesses can be made smarter by basing such calls
>> on response from LID=0 reads.
>
>Let's leave this in.  Failing a get_log page is fine.  The difference
>for discovery controllers is that implementing it is prohibited.
 
Thanks,
Kamaljit