Re: [PATCH v4 2/2] nvme: prevent admin controller from smart log fetch (LID 2)

From: Christoph Hellwig
Date: Tue Jul 22 2025 - 02:30:28 EST


On Mon, Jul 21, 2025 at 10:37:00AM -0700, Kamaljit Singh wrote:
> Similar to a discovery ctrl, prevent an admin-ctrl from getting a smart
> log. LID 2 is optional for admin controllers to support.
>
> In the future when support for the newly added LID=0 (supported log
> pages) is added, GLP accesses can be made smarter by basing such calls
> on response from LID=0 reads.

Umm, as pointed out last time, this log page is prohibited for discovery
controllers, but optional for admin controllers. So I don't see why
we want or need to skip it here.