Re: [PATCH v5 2/3] dt-bindings: leds: issi,is31fl3236: add support for is31fl3236a
From: Krzysztof Kozlowski
Date: Mon Jul 21 2025 - 07:17:25 EST
On 21/07/2025 12:55, Pawel Zalewski wrote:
> Add an additional and optional control property for setting
> the output PWM frequency to 22kHz that exists on is31fl3236a.
> The default is 3kHz and this option puts the operational frequency
> outside of the audible range.
>
> Signed-off-by: Pawel Zalewski <pzalewski@xxxxxxxxxxxxxxxxxxxx>
> ---
> .../devicetree/bindings/leds/issi,is31fl3236.yaml | 24 ++++++++++++++++++++++
> 1 file changed, 24 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/leds/issi,is31fl3236.yaml b/Documentation/devicetree/bindings/leds/issi,is31fl3236.yaml
> index d8164876611f5e629215fe2715ebff1745f93a26..58f5aa4d0b644fe550e2c48b141c41c37fdf98e9 100644
> --- a/Documentation/devicetree/bindings/leds/issi,is31fl3236.yaml
> +++ b/Documentation/devicetree/bindings/leds/issi,is31fl3236.yaml
> @@ -17,6 +17,7 @@ description: |
>
> For more product information please see the links below:
> https://www.lumissil.com/assets/pdf/core/IS31FL3236_DS.pdf
> + https://www.lumissil.com/assets/pdf/core/IS31FL3236A_DS.pdf
> https://www.lumissil.com/assets/pdf/core/IS31FL3235_DS.pdf
> https://www.lumissil.com/assets/pdf/core/IS31FL3218_DS.pdf
> https://www.lumissil.com/assets/pdf/core/IS31FL3216_DS.pdf
> @@ -25,6 +26,7 @@ properties:
> compatible:
> enum:
> - issi,is31fl3236
> + - issi,is31fl3236a
> - issi,is31fl3235
> - issi,is31fl3218
> - issi,is31fl3216
> @@ -40,6 +42,12 @@ properties:
> "#size-cells":
> const: 0
>
> + issi,22kHz-pwm:
I never spotted it before, but this should be issi,22khz-pwm. No
properties use capital letters.
> + type: boolean
> + description:
> + When present, the chip's PWM will operate at ~22kHz as opposed
> + to ~3kHz to move the operating frequency out of the audible range.
> +
Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx>
Best regards,
Krzysztof