Re: [PATCH v5 1/3] dt-bindings: leds: is31fl32xx: convert the binding to yaml

[Krzysztof Kozlowski]

On 21/07/2025 12:55, Pawel Zalewski wrote:
> +
> +properties:
> +  compatible:
> +    enum:
> +      - issi,is31fl3236
> +      - issi,is31fl3235
> +      - issi,is31fl3218
> +      - issi,is31fl3216

Keep alphabetical order.

> +      - si-en,sn3218
> +      - si-en,sn3216

Here as well.


> +
> +  reg:
> +    maxItems: 1
> +
> +  "#address-cells":
> +    const: 1
> +
> +  "#size-cells":
> +    const: 0
> +
> +patternProperties:
> +  "^led@[1-9a-f][0-9a-f]*$":

This still does not match min/max constraints. You already got the
comment on this and nothing improved.

> +    type: object
> +    $ref: common.yaml#
> +    unevaluatedProperties: false
> +
> +    properties:
> +      reg:
> +        description:
> +          LED channel number (1..N)
> +        minimum: 0x1
> +        maximum: 0x24

And these are supposed to be decimal.


Best regards,
Krzysztof