Re: [PATCH v2 0/2] hwmon: (pmbus) Add support for MPS mp2869a/mp29612a controllers

[Henry Wu]

Krzysztof Kozlowski <krzk@xxxxxxxxxx> 於 2025年6月30日 週一 下午7:29寫道：
>
> On 30/06/2025 13:20, tzuhao.wtmh@xxxxxxxxx wrote:
> > From: Henry Wu <Henry_Wu@xxxxxxxxxxxx>
> >
> > Add support for the mp2869a and mp29612a controllers from Monolithic Power
> > Systems, Inc. (MPS). These are dual-loop, digital, multi-phase modulation
> > controllers.
> >
> > ---
> >
> > Changes in v2:
> > - Fix coding style issues.
>
> Which ones? How?

I used checkpatch.pl with the "--strict" option and made the following
adjustments:
- Removed illegal spaces
- Converted comments to block style using /** ... */ instead of //
- Applied lowercase formatting to function names
Would you like me to list all the changes here, or should I include
them in the next patch?

>
> > - Using the pointer to replace the memcpy.
> > - Fix wrong device tree entries.
>
> What exactly? How did you fix it? I see zero changes. Your changelog
> should be specific, not vague.
In patch v1, I placed the mp2869a entry in the wrong order in
trivial-devices.yaml. In patch v2, I reordered it based on the
numerical order in the device name
>
>
> Best regards,
> Krzysztof

Best regards,
Henry Wu