Re: [PATCH 1/5] sched/deadline: Initialize dl_servers after SMP

[Juri Lelli]

On 29/06/25 18:48, Waiman Long wrote:
> On 6/27/25 7:51 AM, Juri Lelli wrote:

...

> > @@ -1652,6 +1664,8 @@ int dl_server_apply_params(struct sched_dl_entity *dl_se, u64 runtime, u64 perio
> >   	int retval = 0;
> >   	int cpus;
> > +	guard(rcu)();
> > +
> 
> Your patch doesn't explain why a RCU guard is needed here?
> sched_init_dl_servers() is the changed caller, but it is called with
> rq_lock_irq held which should implies a RCU read critical section as IRQ is
> disabled.

Yeah, looks like it's not required. Will remove. Thanks for spotting it!

Best,
Juri