Re: [PATCH v3 3/5] arm64: dts: rockchip: add header for RK8XX PMIC constants

[Quentin Schulz]

Hi Sebastian,

On 6/19/25 5:51 PM, Sebastian Reichel wrote:
> Hi,
>
> On Wed, Jun 18, 2025 at 12:32:42PM +0200, Quentin Schulz wrote:
> > From: Quentin Schulz <quentin.schulz@xxxxxxxxx>
> >
> > To make it easier to read the device tree, let's add constants for the
> > rockchip,reset-mode property values that are currently only applicable
> > to RK806 PMIC.
> >
> > Signed-off-by: Quentin Schulz <quentin.schulz@xxxxxxxxx>
> > ---
> >   arch/arm64/boot/dts/rockchip/rk8xx.h | 18 ++++++++++++++++++
>
> I think this header should be in include/dt-bindings/, otherwise the

v2 did that and the feedback from dt-binding people was they didn't want 
(as far as I understood) unused constants as ABI[1][2].

[1] 
https://lore.kernel.org/all/704d75df-a484-4da3-9bcb-85b480e2ecf0@xxxxxxxxxx/
[2] 
https://lore.kernel.org/all/a9baf6b0-b668-4d10-b9de-b63eb3fd8f23@xxxxxxxxxx/

Cheers,
Quentin