Re: [PATCH v3 3/5] arm64: dts: rockchip: add header for RK8XX PMIC constants

[Sebastian Reichel]

Hi,

On Wed, Jun 18, 2025 at 12:32:42PM +0200, Quentin Schulz wrote:
> From: Quentin Schulz <quentin.schulz@xxxxxxxxx>
> 
> To make it easier to read the device tree, let's add constants for the
> rockchip,reset-mode property values that are currently only applicable
> to RK806 PMIC.
> 
> Signed-off-by: Quentin Schulz <quentin.schulz@xxxxxxxxx>
> ---
>  arch/arm64/boot/dts/rockchip/rk8xx.h | 18 ++++++++++++++++++

I think this header should be in include/dt-bindings/, otherwise the
series LGTM.

Greetings,

-- Sebastian

>  1 file changed, 18 insertions(+)
> 
> diff --git a/arch/arm64/boot/dts/rockchip/rk8xx.h b/arch/arm64/boot/dts/rockchip/rk8xx.h
> new file mode 100644
> index 0000000000000000000000000000000000000000..a6fbef71c06493c35b0f3697476167aaafa24f30
> --- /dev/null
> +++ b/arch/arm64/boot/dts/rockchip/rk8xx.h
> @@ -0,0 +1,18 @@
> +/* SPDX-License-Identifier: (GPL-2.0-or-later OR MIT) */
> +/*
> + * Device Tree defines for Rockchip RK8xx PMICs
> + *
> + * Copyright 2025 Cherry Embedded Solutions GmbH
> + *
> + * Author: Quentin Schulz <quentin.schulz@xxxxxxxxx>
> + */
> +
> +#ifndef _DT_MFD_ROCKCHIP_RK8XX_H
> +#define _DT_MFD_ROCKCHIP_RK8XX_H
> +
> +/* For use with rockchip,reset-mode property */
> +#define RK806_RESTART		0
> +#define RK806_RESET		1
> +#define RK806_RESET_NOTIFY	2
> +
> +#endif
> 
> -- 
> 2.49.0
>

Attachment: signature.asc
Description: PGP signature