Re: [PATCH] s390/boot: Use -D__DISABLE_EXPORTS

[Heiko Carstens]

On Fri, Jun 20, 2025 at 05:45:49PM +0200, Petr Pavlu wrote:
> Files in the arch/s390/boot directory reuse logic from the rest of the
> kernel by including certain C and assembly files from the kernel and lib
> directories. Some of these included files contain EXPORT_SYMBOL directives.
> For instance, arch/s390/boot/cmdline.c includes lib/cmdline.c, which
> exports the get_option() function.
> 
> This inclusion triggers genksyms processing for the files in
> arch/s390/boot, which is unnecessary and slows down the build.
> Additionally, when KBUILD_SYMTYPES=1 is set, the generated symtypes data
> contain exported symbols that are duplicated with the main kernel. This
> duplication can confuse external kABI tools that process the symtypes data.
> 
> Address this issue by compiling the files in arch/s390/boot with
> -D__DISABLE_EXPORTS.
> 
> Signed-off-by: Petr Pavlu <petr.pavlu@xxxxxxxx>
> ---
>  arch/s390/boot/Makefile | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)

Reviewed-by: Heiko Carstens <hca@xxxxxxxxxxxxx>