Re: [PATCH v10 1/7] iio: accel: adxl345: simplify interrupt mapping
From: Andy Shevchenko
Date: Mon Jun 23 2025 - 05:25:22 EST
On Sun, Jun 22, 2025 at 03:50:04PM +0000, Lothar Rubusch wrote:
> Refactor the sensor interrupt mapping by utilizing regmap_assign_bits(),
> which accepts a boolean value directly. Introduce a helper function to
> streamline the identification of the configured interrupt line pin. Also,
> use identifiers from units.h to represent the full 8-bit register when
> setting bits.
>
> This is a purely refactoring change and does not affect functionality.
> +static int _get_int_line(struct device *dev, int *irq)
Oh, I should have been clear, I meant the suffix of the name, one still needs
a namespace for this: adxl345_get_int_line().
With that fixed,
Reviewed-by: Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx>
--
With Best Regards,
Andy Shevchenko