Re: [PATCH RESEND v4 0/5] media: i2c: imx214: Add support for more clock frequencies

[Sakari Ailus]

Hi André,

On Sat, Jun 21, 2025 at 11:37:24AM +0200, André Apitzsch via B4 Relay wrote:
> The imx214 driver currently supports only a 24 MHz external clock. But
> there are devices, like Qualcomm-MSM8916-based phones, which cannot
> provide this frequency. To make the sensor usable by those devices, add
> support for additional clock frequencies.
> 
> This series supersedes
> https://lore.kernel.org/linux-media/20250308-imx214_clk_freq-v1-0-467a4c083c35@xxxxxxxxxxx/

Is there a difference in this set from the v4 you posted previously?

> 
> Signed-off-by: André Apitzsch <git@xxxxxxxxxxx>
> ---
> Changes in v4:
> - Add missing colon to error message
> - Add A-b, R-b tags
> - Link to v3: https://lore.kernel.org/r/20250521-imx214_ccs_pll-v3-0-bfb4a2b53d14@xxxxxxxxxxx
> 
> Changes in v3:
> - Limit range of pll_ip_clk_freq_hz (Sakari)
> - Drop unneeded 'ret'
> - Use pll.pixel_rate_csi for bit rate calculation
> - Add patch that deprecates the clock-frequency property
> - Link to v2: https://lore.kernel.org/r/20250505-imx214_ccs_pll-v2-0-f50452061ff1@xxxxxxxxxxx
> 
> Changes in v2:
> - Add A-b tags
> - Switch to v4l2_ctrl_s_ctrl_int64() to acquire the control handler mutex
> - Add error handling for v4l2_ctrl_s_ctrl_int64() and
>   imx214_pll_update()
> - Replace "read clock frequency from dt" patch by "remove hard-coded
>   external clock frequency" patch
> - Link to v1:
>   https://lore.kernel.org/r/20250415-imx214_ccs_pll-v1-0-d3d7748e5fbd@xxxxxxxxxxx
> 
> ---
> André Apitzsch (5):
>       media: i2c: imx214: Reorder imx214_parse_fwnode call
>       media: i2c: imx214: Prepare for variable clock frequency
>       media: i2c: imx214: Make use of CCS PLL calculator
>       media: dt-bindings: sony,imx214: Deprecate property clock-frequency
>       media: i2c: imx214: Remove hard-coded external clock frequency
> 
>  .../devicetree/bindings/media/i2c/sony,imx214.yaml |  29 ++-
>  drivers/media/i2c/Kconfig                          |   1 +
>  drivers/media/i2c/imx214.c                         | 263 ++++++++++++++++-----
>  3 files changed, 217 insertions(+), 76 deletions(-)
> ---
> base-commit: 176e917e010cb7dcc605f11d2bc33f304292482b
> change-id: 20250406-imx214_ccs_pll-e4aed0e9e532
> 
> Best regards,

-- 
Regards,

Sakari Ailus