Re: [PATCH 1/9] iio: adc: ad_sigma_delta: sort includes
From: Andy Shevchenko
Date: Mon Jun 23 2025 - 02:50:46 EST
On Sun, Jun 22, 2025 at 03:37:33PM +0100, Jonathan Cameron wrote:
> On Fri, 20 Jun 2025 17:20:07 -0500
> David Lechner <dlechner@xxxxxxxxxxxx> wrote:
...
> > #include <linux/kernel.h>
> Andy normally points this out (and may well do here) but in
> general if we are tidying up headers we should try to drop includes
> of kernel.h if favour of more specific headers.
>
> Doesn't need to be in same patch as this one though!
>
> This is trivial and correct as it stands and would want to be
> done as a precursor to any actual changes anyway.
Yeah, kernel.h in the (leaf) drivers is a red flag to me.
But replacing it is out of scope of this patch and may be
done separately. My only point that please do it rather
sooner.
--
With Best Regards,
Andy Shevchenko