Re: [PATCH net-next] ethtool: pse-pd: Add missing linux/export.h include
From: Jakub Kicinski
Date: Sat Jun 21 2025 - 10:00:56 EST
On Fri, 20 Jun 2025 11:14:52 +0100 Simon Horman wrote:
> On Thu, Jun 19, 2025 at 06:25:47PM +0200, Kory Maincent wrote:
> > Fix missing linux/export.h header include in net/ethtool/pse-pd.c to resolve
> > build warning reported by the kernel test robot.
> >
> > Reported-by: kernel test robot <lkp@xxxxxxxxx>
> > Closes: https://lore.kernel.org/oe-kbuild-all/202506200024.T3O0FWeR-lkp@xxxxxxxxx/
> > Signed-off-by: Kory Maincent <kory.maincent@xxxxxxxxxxx>
>
> The change that introduced this warning introduced a log of such warnings.
> Including a lot in the Networking subsystem. (I did not count them.)
>
> So I agree with the point from Sean Christopherson [*] is that if the patch
> that introduced the warnings isn't reverted
It was reverted, thankfully. So I assume we treat this patch as
a normal "include what you need" case and therefore apply.. ?
> then a more comprehensive approach is needed to address these warnings.
>
> [*] Re: [PATCH 3/6] KVM: x86: hyper-v: Fix warnings for missing export.h header inclusion
> https://lore.kernel.org/netdev/aEl9kO81-kp0hhw0@xxxxxxxxxx/