Re: [Patch v4 09/13] perf/x86/intel: Setup PEBS data configuration and enable legacy groups

[Peter Zijlstra]

On Fri, Jun 20, 2025 at 10:39:05AM +0000, Dapeng Mi wrote:

> +		if (cpuc->n_pebs == cpuc->n_large_pebs)
> +			index.split.thresh = ARCH_PEBS_THRESH_MUL;
> +		else
> +			index.split.thresh = ARCH_PEBS_THRESH_SINGLE;

> +	if (cpuc->n_pebs == cpuc->n_large_pebs)
> +		index.split.thresh = ARCH_PEBS_THRESH_MUL;
> +	else
> +		index.split.thresh = ARCH_PEBS_THRESH_SINGLE;

> +/*
> + * The largest PEBS record could consume a page, ensure
> + * a record at least can be written after triggering PMI.
> + */
> +#define ARCH_PEBS_THRESH_MUL	((PEBS_BUFFER_SIZE - PAGE_SIZE) >> PEBS_BUFFER_SHIFT)
> +#define ARCH_PEBS_THRESH_SINGLE	1

Can we please do something like s/MUL/MULTI/ or so. My brain keeps
trying to make it MULtiply and that doesn't really work.