Re: [PATCH v3 2/2] reset: eswin: Add eic7700 reset driver

[Krzysztof Kozlowski]

On 19/06/2025 10:01, dongxuyang@xxxxxxxxxxxxxxxxxx wrote:
> +
> +static const struct reset_control_ops eswin_reset_ops = {
> +	.reset = eswin_reset_reset,
> +	.assert = eswin_reset_assert,
> +	.deassert = eswin_reset_deassert,
> +};
> +
> +static int eswin_reset_of_xlate_lookup_id(int id, void *p, void *data)
> +{
> +	struct of_phandle_args *reset_spec = data;

Still wrong cast.

What is the type? You got exactly that question. How did you resolve it?

> +	struct eswin_reset_control *slot_control = p;
> +
> +	if (reset_spec->args[0] == slot_control->dev_id &&
> +	    reset_spec->args[1] == slot_control->reset_bit)
> +		return id;
> +
> +	return 0;
> +}
> +
Best regards,
Krzysztof