Re: [PATCH v3 0/2] Add driver support for ESWIN eic7700 SoC reset controller

[Krzysztof Kozlowski]

On 19/06/2025 09:58, dongxuyang@xxxxxxxxxxxxxxxxxx wrote:
> From: Xuyang Dong <dongxuyang@xxxxxxxxxxxxxxxxxx>
> 
> There are some register offsets in reset dt-bindings. It could be used.
> Therefore, we want to keep these bindings. I don't known if it meets
> the requirements.
> 
> PIPE_RST_CTRL, TBU_RST_CTRL and TEST_RST_CTRL are not used in this
> driver. Therefore, these are left out.
> 
> Updates:
> 
>   dt-bindings: reset: eswin: Documentation for eic7700 SoC
>   v2 -> v3:
>     1. Drop syscon and simple-mfd from yaml and code, because these are
>        not necessary.
>     2. Update description to introduce reset controller.
>     3. Add reset control indices for dt-bindings.
>     4. Keep the register offsets in dt-bindings.

No, drop. Register offsets are not bindings. That was last comment, so
don't keep them. Remove them.


Best regards,
Krzysztof