RE: [PATCH 1/1] EDAC/igen6: Fix NULL pointer dereference

[Zhuo, Qiuxu]

Hi Tony,

> From: Luck, Tony <tony.luck@xxxxxxxxx>
> [...]
> >
> > This issue occurred because one memory controller was fused off by
> 
> Maybe "disabled by BIOS" rather than "fused off by BIOS".

The phrase "disabled by BIOS" should be more appropriate.
Will update it in v2. Thanks.
 
> > the BIOS but the igen6_edac driver still checked all the memory
> > controllers, including this absent one, to identify the source of the
> [...]
> >
> > -	if (lmc < res_cfg->num_imc)
> > +	if (lmc < res_cfg->num_imc) {
> >  		igen6_printk(KERN_WARNING, "Expected %d mcs, but
> only %d detected.",
> >  			     res_cfg->num_imc, lmc);
> 
> KERN_WARNING seems overly dramatic. BIOS likely had good reasons to
> disable the memory controller (e.g. it isn't connected to any DIMM slots on
> the motherboard for this system). So there's nothing actually wrong that
> needs to be fixed.

Yes. That's true. 

> KERN_INFO is enough. Perhaps KERN_DEBUG?

Will change the log level to "KERN_DEBUG" in v2 to reduce noise.

- Qiuxu