Re: [PATCH] hwmon: (corsair-cpro) Change dependency from HID to HIDRAW

[Guenter Roeck]

On 6/18/25 00:28, dongfengweixiao@xxxxxxxxx wrote:
> From: "Dee.H.Y" <dongfengweixiao@xxxxxxxxx>
>
> This patch updates the dependency of the CORSAIR_CPRO driver in the
> hwmon subsystem. Previously, the driver relied on HID, but now it

From Documentation/process/submitting-patches.rst:

Describe your changes in imperative mood, e.g. "make xyzzy do frotz"
instead of "[This patch] makes xyzzy do frotz" or "[I] changed xyzzy
to do frotz", as if you are giving orders to the codebase to change
its behaviour.

What is "previously" ? The driver always used HID_CONNECT_HIDRAW.

Either case, I do not think this patch is warranted. CONFIG_HIDRAW
creates /dev/hidraw for use by applications. This driver does not
need such an application to work. If you disagree, please provide
logs showing that the driver does not work with CONFIG_HIDRAW=n.

Thanks,
Guenter

> depends on HIDRAW. This change is aligned with the implementation
> in the `ccp_probe()` function, where `HID_CONNECT_HIDRAW` is used,
> indicating that the HID raw interface is required for proper operation.
>
> Signed-off-by: Dee.H.Y <dongfengweixiao@xxxxxxxxx>
> ---
>   drivers/hwmon/Kconfig | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/hwmon/Kconfig b/drivers/hwmon/Kconfig
> index 08a3c863f80a..3f128cacb486 100644
> --- a/drivers/hwmon/Kconfig
> +++ b/drivers/hwmon/Kconfig
> @@ -475,7 +475,7 @@ config SENSORS_CHIPCAP2
>   
>   config SENSORS_CORSAIR_CPRO
>   	tristate "Corsair Commander Pro controller"
> -	depends on HID
> +	depends on HIDRAW
>   	help
>   	  If you say yes here you get support for the Corsair Commander Pro
>   	  controller.