Re: [PATCH v1 1/1] iio: imu: inv_icm42600: Convert to uXX and sXX integer types
From: Andy Shevchenko
Date: Tue Jun 17 2025 - 14:34:37 EST
On Tue, Jun 17, 2025 at 5:43 PM Jean-Baptiste Maneyrol
<Jean-Baptiste.Maneyrol@xxxxxxx> wrote:
> >From: Andy Shevchenko <andy.shevchenko@xxxxxxxxx>
> >Sent: Monday, June 16, 2025 16:33
> >On Mon, Jun 16, 2025 at 5:16 PM Jean-Baptiste Maneyrol
> ><Jean-Baptiste.Maneyrol@xxxxxxx> wrote:
> >
> >> thanks a lot for having done all the work.
> >
> >Please, avoid top-posting!
> >
> >> Do you think it is possible to add a fixes tag so it can be backported to ease automatic backport of further patches?
> >> Otherwise for sure all further fixes will have to be backported manually.
> >
> >The idea behind the series that it may depend on some kind of
> >cleanups. In such a case (according to Greg KH) no need to have Fixes
> >tag on a cleanup, because it's confusing. On the contrary the
> >infrastructure for stable kernels will catch this up. You need to
> >follow the Documentation on how to submit for stable (basically the
> >main hint is to use stable@ in the Cc line _inside_ the commit
> >message, as a tag).
> >
> >> The driver code is full of intXX_t and uintXX_t types which is
> >> not the pattern we use in the IIO subsystem. Switch the driver
> >> to use kernel internal types for that. No functional changes.
> >> As noted before the pattern is used in less than 10% files in IIO,
> >> So it's safe to assume that IIO prefers uXX/sXX types over C99 ones.
> >
>
> it is good for me if we can add Cc to stable.
> I don't know if I need to add the Cc tag here or when a fixed patch will
> require the rework. In doubt, here it is.
>
> Acked-by: Jean-Baptiste Maneyrol <jean-baptiste.maneyrol@xxxxxxx>
> Cc: stable@xxxxxxxxxxxxxxx
It makes no sense here. This is a standalone change. It's not part of
any "fixes" series. You need to attach this patch to your series as
patch 1 and mark Cc stable all of the patches.
--
With Best Regards,
Andy Shevchenko