Re: [PATCH v1 1/1] iio: imu: inv_icm42600: Convert to uXX and sXX integer types

From: Jean-Baptiste Maneyrol
Date: Tue Jun 17 2025 - 10:48:10 EST


>
>________________________________________
>From: Andy Shevchenko <andy.shevchenko@xxxxxxxxx>
>Sent: Monday, June 16, 2025 16:33
>To: Jean-Baptiste Maneyrol <Jean-Baptiste.Maneyrol@xxxxxxx>
>Cc: Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx>; Jonathan Cameron <Jonathan.Cameron@xxxxxxxxxx>; linux-iio@xxxxxxxxxxxxxxx <linux-iio@xxxxxxxxxxxxxxx>; linux-kernel@xxxxxxxxxxxxxxx <linux-kernel@xxxxxxxxxxxxxxx>; Jonathan Cameron <jic23@xxxxxxxxxx>; David Lechner <dlechner@xxxxxxxxxxxx>; Nuno Sá <nuno.sa@xxxxxxxxxx>; Andy Shevchenko <andy@xxxxxxxxxx>
>Subject: Re: [PATCH v1 1/1] iio: imu: inv_icm42600: Convert to uXX and sXX integer types
> 
>This Message Is From an External Sender
>This message came from outside your organization.
> 
>On Mon, Jun 16, 2025 at 5:16 PM Jean-Baptiste Maneyrol
><Jean-Baptiste.Maneyrol@xxxxxxx> wrote:
>
>> thanks a lot for having done all the work.
>
>Please, avoid top-posting!
>
>> Do you think it is possible to add a fixes tag so it can be backported to ease automatic backport of further patches?
>> Otherwise for sure all further fixes will have to be backported manually.
>
>The idea behind the series that it may depend on some kind of
>cleanups. In such a case (according to Greg KH) no need to have Fixes
>tag on a cleanup, because it's confusing. On the contrary the
>infrastructure for stable kernels will catch this up. You need to
>follow the Documentation on how to submit for stable (basically the
>main hint is to use stable@ in the Cc line _inside_ the commit
>message, as a tag).
>
>> The driver code is full of intXX_t and uintXX_t types which is
>> not the pattern we use in the IIO subsystem. Switch the driver
>> to use kernel internal types for that. No functional changes.
>>
>> Signed-off-by: Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx>
>> ---
>>
>> As noted before the pattern is used in less than 10% files in IIO,
>> So it's safe to assume that IIO prefers uXX/sXX types over C99 ones.
>
>--
>With Best Regards,
>Andy Shevchenko
>

Hello Andy,

it is good for me if we can add Cc to stable.
I don't know if I need to add the Cc tag here or when a fixed patch will
require the rework. In doubt, here it is.

Acked-by: Jean-Baptiste Maneyrol <jean-baptiste.maneyrol@xxxxxxx>
Cc: stable@xxxxxxxxxxxxxxx

Thanks,
JB