Re: [PATCH v2 1/2] dt-bindings: i3c: Add adi-i3c-master

[Conor Dooley]

On Tue, Jun 17, 2025 at 04:50:43PM +0200, Jorge Marques wrote:
> On Fri, Jun 06, 2025 at 05:08:45PM +0100, Conor Dooley wrote:
> > On Fri, Jun 06, 2025 at 03:21:02PM +0200, Jorge Marques wrote:
> > > Add bindings doc for ADI I3C Controller IP core, a FPGA synthesizable IP
> > > core that implements the MIPI I3C Basic controller specification.
> > > 
> > > Signed-off-by: Jorge Marques <jorge.marques@xxxxxxxxxx>
> > > ---
> > >  .../devicetree/bindings/i3c/adi,i3c-master.yaml    | 63 ++++++++++++++++++++++
> > >  MAINTAINERS                                        |  5 ++
> > >  2 files changed, 68 insertions(+)
> > > 
> > > diff --git a/Documentation/devicetree/bindings/i3c/adi,i3c-master.yaml b/Documentation/devicetree/bindings/i3c/adi,i3c-master.yaml
> > > new file mode 100644
> > > index 0000000000000000000000000000000000000000..e7fae394ad8fd4143eb1fffb9591a30a2d6cc6ac
> > > --- /dev/null
> > > +++ b/Documentation/devicetree/bindings/i3c/adi,i3c-master.yaml
> > > @@ -0,0 +1,63 @@
> > > +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause
> > > +%YAML 1.2
> > > +---
> > > +$id: http://devicetree.org/schemas/i3c/adi,i3c-master.yaml#
> > > +$schema: http://devicetree.org/meta-schemas/core.yaml#
> > > +
> > > +title: Analog Devices I3C Controller
> > > +
> > > +description: |
> > > +  The ADI I3C controller implements a subset of the I3C-basic specification to
> > > +  interface I3C and I2C peripherals [1].
> > > +
> > > +  [1] https://analogdevicesinc.github.io/hdl/library/i3c_controller
> > > +
> > > +maintainers:
> > > +  - Jorge Marques <jorge.marques@xxxxxxxxxx>
> > > +
> > > +properties:
> > > +  compatible:
> > > +    const: adi,i3c-master
> > 
> Hi Conor,
> > Seeing this with no versioning info is pretty suspect.
> > The adi spi, pwm, axi-dmac etc all have versioning info, please try to
> > emulate that.
> > 
> > Otherwise, I think this is okay.
> > 
> > Cheers,
> > Conor.
> > 
> The driver checks the IP version via register access, for the other adi
> ips, the -x.00.a suffix was never updated. For example, the axi-dmac
> current IP version is v4.5.64 while the compatible still is 1.00.a and
> there is a mention of v4.3.a in the binding. It is unclear whether
> suffixing it with "-1.00.a" would be useful, or if the time comes call
> the new "adi,i3c-master-2".
> 
> Do you still think it is necessary?

I do, yes. In the other cases, if a new version comes out that has some
sort of meaningful difference a new compatible can be added. Until then,
using the -1.00.a one is okay.

Attachment: signature.asc
Description: PGP signature