Re: [PATCH] serial: core: restore of_node information in sysfs

From: Aidan Stewart
Date: Tue Jun 17 2025 - 11:53:04 EST


On Tue, 2025-06-17 at 06:44 +0200, Greg KH wrote:
>
> On Mon, Jun 16, 2025 at 10:21:54AM -0600, Aidan Stewart wrote:
> >
> >
> > +     if (IS_ENABLED(CONFIG_OF)) {
> > +             device_set_of_node_from_dev(dev, parent_dev);
> > +     }
>
> Did this pass checkpatch.pl?
I ran checkpatch.pl with the --strict option and I didn't get any warnings
or errors. Is there a style issue you would like me to fix?

> And why is the if statement needed?
I guess it's not really needed. I was trying to avoid the call for non-DT
systems, but it should still be safe to do. I will remove it in v2.

> thanks,
>
> greg k-h

--
Thanks,

Aidan Stewart