Re: [PATCH v3 1/2] rust: Introduce file_from_location()

[Miguel Ojeda]

On Mon, Jun 16, 2025 at 5:36 PM Boqun Feng <boqun.feng@xxxxxxxxx> wrote:
>
> introduce a file_from_location() function, which return a warning string

returns

>  #![cfg_attr(not(CONFIG_RUSTC_HAS_COERCE_POINTEE), feature(coerce_unsized))]
>  #![cfg_attr(not(CONFIG_RUSTC_HAS_COERCE_POINTEE), feature(dispatch_from_dyn))]
>  #![cfg_attr(not(CONFIG_RUSTC_HAS_COERCE_POINTEE), feature(unsize))]
> +#![cfg_attr(CONFIG_RUSTC_HAS_LOCATION_FILE_WITH_NUL, feature(file_with_nul))]

I would change the config name to `CONFIG_RUSTC_HAS_FILE_WITH_NUL`
since that is the actual name, i.e. without "location".

By the way, please add a comment on top, like the others, i.e. something like:

    //
    // `feature(file_with_nul)` is expected to become stable. Before Rust
    // 1.89.0, it did not exist, so enable it conditionally.

Alice: the tracking issue uses the wrong name, i.e. with the
`location_*` prefix.

> +/// If `file_with_nul()` is not available, returns a string that warns about it.

Could we give a couple examples, i.e. of each case? (No need to assert anything)

> +        use crate::c_str;

Do we need the `use`?

Thanks!

Cheers,
Miguel