Re: [PATCH 2/5] dt-bindings: iommu: verisilicon: Add binding for VSI IOMMU

[Nicolas Dufresne]

Hi,

Le lundi 16 juin 2025 à 16:14 +0100, Conor Dooley a écrit :
> > +properties:
> > +  compatible:
> > +    oneOf:
> > +      - items:
> > +          - const: verisilicon,iommu
> 
> You're missing a soc-specific compatible at the very least here, but is
> there really no versioning on the IP at all? I'd be surprised if
> verisilicon only produced exactly one version of an iommu IP.

I've dumped the HW ID (base + 6*4), and it reports this IP as an "MM 1.2.0"
(0x4d4d1200).

Note, all VSI IP for which rockchip did not rewrite the register
interface expose a HW ID register, but the from and location can vary.
This one is following the old school H1/G1/G2 style, using ascii to
idenity the core type. Interesting fact too, the register layout seem
to be the same as the Vivante MMU (which is hidden inside the etnaviv
driver).

I'm fine with having a soc specific compatible, just documenting
some fact I could dump.

cheers,
Nicolas

Attachment: signature.asc
Description: This is a digitally signed message part