Re: [PATCH v5 4/9] arm64: dts: imx93: move i.MX93 specific part from imx91_93_common.dtsi to imx93.dtsi

From: Krzysztof Kozlowski
Date: Mon Jun 16 2025 - 06:33:34 EST


On 16/06/2025 09:42, Joy Zou wrote:
>
>> -----Original Message-----
>> From: Krzysztof Kozlowski <krzk@xxxxxxxxxx>
>> Sent: 2025年6月13日 18:44
>> To: Joy Zou <joy.zou@xxxxxxx>; robh@xxxxxxxxxx; krzk+dt@xxxxxxxxxx;
>> conor+dt@xxxxxxxxxx; shawnguo@xxxxxxxxxx; s.hauer@xxxxxxxxxxxxxx;
>> catalin.marinas@xxxxxxx; will@xxxxxxxxxx; andrew+netdev@xxxxxxx;
>> davem@xxxxxxxxxxxxx; edumazet@xxxxxxxxxx; kuba@xxxxxxxxxx;
>> pabeni@xxxxxxxxxx; mcoquelin.stm32@xxxxxxxxx;
>> alexandre.torgue@xxxxxxxxxxx; ulf.hansson@xxxxxxxxxx;
>> richardcochran@xxxxxxxxx; kernel@xxxxxxxxxxxxxx; festevam@xxxxxxxxx
>> Cc: devicetree@xxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx;
>> imx@xxxxxxxxxxxxxxx; linux-arm-kernel@xxxxxxxxxxxxxxxxxxx;
>> netdev@xxxxxxxxxxxxxxx; linux-stm32@xxxxxxxxxxxxxxxxxxxxxxxxxxxx;
>> linux-pm@xxxxxxxxxxxxxxx; Frank Li <frank.li@xxxxxxx>; Ye Li <ye.li@xxxxxxx>;
>> Jacky Bai <ping.bai@xxxxxxx>; Peng Fan <peng.fan@xxxxxxx>; Aisheng Dong
>> <aisheng.dong@xxxxxxx>; Clark Wang <xiaoning.wang@xxxxxxx>
>> Subject: Re: [PATCH v5 4/9] arm64: dts: imx93: move i.MX93 specific
>> part from imx91_93_common.dtsi to imx93.dtsi
>>
>> On 13/06/2025 12:02, Joy Zou wrote:
>>> Move i.MX93 specific part from imx91_93_common.dtsi to imx93.dtsi.
>>
>> You just moved them to the common file. Why are you moving the same line
>> again?
> Thanks for your comments!
> These are the differences for the convenience of review.

So you just keep changing same lines for a review? No. It makes
everything difficult to review.

Organize your patches in logical chunks, as requested by submitting patches.



Best regards,
Krzysztof