RE: Re: [PATCH v5 4/9] arm64: dts: imx93: move i.MX93 specific part from imx91_93_common.dtsi to imx93.dtsi
From: Joy Zou
Date: Mon Jun 16 2025 - 03:42:31 EST
> -----Original Message-----
> From: Krzysztof Kozlowski <krzk@xxxxxxxxxx>
> Sent: 2025年6月13日 18:44
> To: Joy Zou <joy.zou@xxxxxxx>; robh@xxxxxxxxxx; krzk+dt@xxxxxxxxxx;
> conor+dt@xxxxxxxxxx; shawnguo@xxxxxxxxxx; s.hauer@xxxxxxxxxxxxxx;
> catalin.marinas@xxxxxxx; will@xxxxxxxxxx; andrew+netdev@xxxxxxx;
> davem@xxxxxxxxxxxxx; edumazet@xxxxxxxxxx; kuba@xxxxxxxxxx;
> pabeni@xxxxxxxxxx; mcoquelin.stm32@xxxxxxxxx;
> alexandre.torgue@xxxxxxxxxxx; ulf.hansson@xxxxxxxxxx;
> richardcochran@xxxxxxxxx; kernel@xxxxxxxxxxxxxx; festevam@xxxxxxxxx
> Cc: devicetree@xxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx;
> imx@xxxxxxxxxxxxxxx; linux-arm-kernel@xxxxxxxxxxxxxxxxxxx;
> netdev@xxxxxxxxxxxxxxx; linux-stm32@xxxxxxxxxxxxxxxxxxxxxxxxxxxx;
> linux-pm@xxxxxxxxxxxxxxx; Frank Li <frank.li@xxxxxxx>; Ye Li <ye.li@xxxxxxx>;
> Jacky Bai <ping.bai@xxxxxxx>; Peng Fan <peng.fan@xxxxxxx>; Aisheng Dong
> <aisheng.dong@xxxxxxx>; Clark Wang <xiaoning.wang@xxxxxxx>
> Subject: Re: [PATCH v5 4/9] arm64: dts: imx93: move i.MX93 specific
> part from imx91_93_common.dtsi to imx93.dtsi
>
> On 13/06/2025 12:02, Joy Zou wrote:
> > Move i.MX93 specific part from imx91_93_common.dtsi to imx93.dtsi.
>
> You just moved them to the common file. Why are you moving the same line
> again?
Thanks for your comments!
These are the differences for the convenience of review.
>
> >
> > Signed-off-by: Joy Zou <joy.zou@xxxxxxx>
> > ---
If Shawn thinks the need to merge into the previous commit, can do it during the merge.
> > .../boot/dts/freescale/imx91_93_common.dtsi | 140 +---------------
> > arch/arm64/boot/dts/freescale/imx93.dtsi | 155
> ++++++++++++++++++
> > 2 files changed, 157 insertions(+), 138 deletions(-)> diff --git
> > a/arch/arm64/boot/dts/freescale/imx91_93_common.dtsi
> > b/arch/arm64/boot/dts/freescale/imx91_93_common.dtsi
> > index 64cd0776b43d..da4c1c0699b3 100644
> > --- a/arch/arm64/boot/dts/freescale/imx91_93_common.dtsi
> > +++ b/arch/arm64/boot/dts/freescale/imx91_93_common.dtsi
> > @@ -1,6 +1,6 @@
> > // SPDX-License-Identifier: (GPL-2.0+ OR MIT)
> > /*
> > - * Copyright 2022 NXP
> > + * Copyright 2025 NXP
>
> Why?
Will restore it!
BR
Joy Zou
>
>
> Best regards,
> Krzysztof