Re: [PATCH V2 0/3] Add level shifter support for qualcomm SOC's

[Sarthak Garg]

On 5/27/2025 8:05 PM, Ulf Hansson wrote:
> On Fri, 23 May 2025 at 20:25, Konrad Dybcio
> <konrad.dybcio@xxxxxxxxxxxxxxxx> wrote:
> > On 5/23/25 12:57 PM, Sarthak Garg wrote:
> > > Add level shifter support for qualcomm SOC's.
> > >
> > > - Changed from v1
> > >      - As suggested by Krzysztof Kozlowski redesigned logic to use
> > >      compatible property for adding this level shifter support.
> > >      - Addressed Adrian Hunter comments on V1 with resepect to
> > >        checkpatch.
> > >      - Cleared the bits first and then set bits in
> > >        sdhci_msm_execute_tuning as suggested by Adrian Hunter.
> > >      - Upated the if condition logic in msm_set_clock_rate_for_bus_mode
> > >        as suggested by Adrian Hunter.
> >
> > During internal review I suggested we could introduce a generic quirk,
> > perhaps called "max-hs-frequency" which would update this
> > currently-constant value:
> >
> > ---------------- drivers/mmc/core/sd.c ----------------
> > if (status[13] & SD_MODE_HIGH_SPEED)
> >          card->sw_caps.hs_max_dtr = HIGH_SPEED_MAX_DTR;
> > -------------------------------------------------------
> >
> > (50 MHz)
> >
> > which I believe is where it comes from
>
> I agree that a DT property for the mmc controller would make sense.
>
> Although, this seems limited to SD UHS-I speed modes, so perhaps
> "max-sd-uhs-frequency" would be a better name for it?
>
> Kind regards
> Uffe

Sure will update this logic in V3.