Re: [PATCH V2 0/3] Add level shifter support for qualcomm SOC's

From: Sarthak Garg
Date: Mon Jun 16 2025 - 03:13:59 EST




On 5/23/2025 11:55 PM, Konrad Dybcio wrote:
On 5/23/25 12:57 PM, Sarthak Garg wrote:
Add level shifter support for qualcomm SOC's.

- Changed from v1
- As suggested by Krzysztof Kozlowski redesigned logic to use
compatible property for adding this level shifter support.
- Addressed Adrian Hunter comments on V1 with resepect to
checkpatch.
- Cleared the bits first and then set bits in
sdhci_msm_execute_tuning as suggested by Adrian Hunter.
- Upated the if condition logic in msm_set_clock_rate_for_bus_mode
as suggested by Adrian Hunter.

During internal review I suggested we could introduce a generic quirk,
perhaps called "max-hs-frequency" which would update this
currently-constant value:

---------------- drivers/mmc/core/sd.c ----------------
if (status[13] & SD_MODE_HIGH_SPEED)
card->sw_caps.hs_max_dtr = HIGH_SPEED_MAX_DTR;
-------------------------------------------------------

(50 MHz)

which I believe is where it comes from

Konrad

Sure will introduce a new dtsi flag "max-sd-uhs-frequency" and update this hs_max_dtr value in V3.