Re: [PATCH v4 2/2] iio: imu: inv_icm42600: add wakeup functionality for Wake-on-Motion

[Jean-Baptiste Maneyrol]

>
>________________________________________
>From: Andy Shevchenko <andriy.shevchenko@xxxxxxxxx>
>Sent: Friday, June 13, 2025 10:31
>To: Jean-Baptiste Maneyrol <Jean-Baptiste.Maneyrol@xxxxxxx>
>Cc: Jonathan Cameron <jic23@xxxxxxxxxx>; Lars-Peter Clausen <lars@xxxxxxxxxx>; David Lechner <dlechner@xxxxxxxxxxxx>; Nuno Sá <nuno.sa@xxxxxxxxxx>; Andy Shevchenko <andy@xxxxxxxxxx>; linux-iio@xxxxxxxxxxxxxxx <linux-iio@xxxxxxxxxxxxxxx>; linux-kernel@xxxxxxxxxxxxxxx <linux-kernel@xxxxxxxxxxxxxxx>
>Subject: Re: [PATCH v4 2/2] iio: imu: inv_icm42600: add wakeup functionality for Wake-on-Motion
> 
>This Message Is From an External Sender
>This message came from outside your organization.
> 
>On Fri, Jun 13, 2025 at 09:34:27AM +0200, Jean-Baptiste Maneyrol via B4 Relay wrote:
>> From: Jean-Baptiste Maneyrol <jean-baptiste.maneyrol@xxxxxxx>
>> 
>> When Wake-on-Motion is on, enable system wakeup and keep the chip on
>> for waking up the system with an interrupt.
>
>...
>
>> +	/* accel events are wakeup capable */
>> +	devm_device_init_wakeup(&indio_dev->dev);
>
>No checking for return code? Why is it okay? This needs a really good comment,
>and even better a (info / debug) message when it fails if it's not a fatal
>error.

Sorry, just forgot. I will add it in v5.

>
>-- 
>With Best Regards,
>Andy Shevchenko
>
>
>