Re: [PATCH v4 2/2] iio: imu: inv_icm42600: add wakeup functionality for Wake-on-Motion

From: Andy Shevchenko
Date: Fri Jun 13 2025 - 04:32:01 EST


On Fri, Jun 13, 2025 at 09:34:27AM +0200, Jean-Baptiste Maneyrol via B4 Relay wrote:
> From: Jean-Baptiste Maneyrol <jean-baptiste.maneyrol@xxxxxxx>
>
> When Wake-on-Motion is on, enable system wakeup and keep the chip on
> for waking up the system with an interrupt.

...

> + /* accel events are wakeup capable */
> + devm_device_init_wakeup(&indio_dev->dev);

No checking for return code? Why is it okay? This needs a really good comment,
and even better a (info / debug) message when it fails if it's not a fatal
error.

--
With Best Regards,
Andy Shevchenko