Re: [PATCH v2 4/7] irqchip: MIPS P800 variant of aclint-sswi

[Vladimir Kondratiev]

>> +config ACLINT_SSWI
>> +     bool
>> +
>> +config MIPS_P8700_ACLINT_SSWI
>> +     bool "MIPS P8700 ACLINT S-mode IPI Interrupt Controller"
>> +     depends on RISCV
>> +     depends on SMP
>> +     select IRQ_DOMAIN_HIERARCHY
>> +     select GENERIC_IRQ_IPI_MUX
>> +     select ACLINT_SSWI
>> +     help
>> +       This enables support for MIPS P8700 specific ACLINT SSWI device
>> +
>> +       If you don't know what to do here, say Y.
>> +
>>  config THEAD_C900_ACLINT_SSWI
>>        bool "THEAD C9XX ACLINT S-mode IPI Interrupt Controller"
>>        depends on RISCV
>>        depends on SMP
>>        select IRQ_DOMAIN_HIERARCHY
>>        select GENERIC_IRQ_IPI_MUX
>> +     select ACLINT_SSWI
>>        help
>>          This enables support for T-HEAD specific ACLINT SSWI device
>>          support.
>
>That's just exactly the same thing twice for no value. Just rename it to
>ACLINT_SSWI and have a list of supported chips in the help text.
>
>The only issue with the rename is, that oldconfig will drop the then
>non-existing THEAD_C900_ACLINT_SSWI entry in the previous config. That's
>not the end of the world and if really desired this can be solved by
>having:
>
>config ACLINT_SSWI
>        bool "RISCV ACLINT ...."
>        depends on RISCV
>        depends on SMP
>        select IRQ_DOMAIN_HIERARCHY
>        select GENERIC_IRQ_IPI_MUX
>        select ACLINT_SSWI
>        help
>          This enables support for ACLINT SSWI device on THEAD C9XX and
>          MIPS P8700 devices.
>
># Backwards compatibility so oldconfig does not drop it.
>config THEAD_C900_ACLINT_SSWI
>        select ACLINT_SSWI

Thanks, doing this. Indeed it is more compact and clean.
Submitting v3