Re: [PATCH v2 2/3] dt-bindings: arm: imx8mp: Add Ultratronik Ultra-MACH SBC

From: Krzysztof Kozlowski
Date: Thu Jun 12 2025 - 07:01:17 EST


On 12/06/2025 12:09, Goran Radenovic wrote:
> Hi Krzysztof,
>
> Thanks for the feedback, and you're absolutely right — I made a mistake
> here.
>
> That said, I’m still a bit confused by your earlier comment:
>
> "That's just part of the standard/first enum."
>
> I’m introducing a new board from a new manufacturer, so I expected to
> add a new enum block — similar to how it's done for other vendor entries

No, you are expected to add to existing enum.

> in the same file. I ran dt_binding_check, and it passed without errors
> for this structure.

Not possible. The syntax is clearly wrong, so there is no way it passed
any tests. And Rob's report is a proof of that.

>
> Could you clarify which “standard/first enum” you were referring to?
> Should all i.MX8MP-based boards share a single enum block, regardless of
> vendor?

Don't they? Look around in this file.

>
> Thanks again for your guidance.

Don't top post but reply inline.

Best regards,
Krzysztof