Re: [PATCH v2 2/3] dt-bindings: arm: imx8mp: Add Ultratronik Ultra-MACH SBC

[Goran Radenovic]

Hi Krzysztof,

Thanks for the feedback, and you're absolutely right — I made a mistake 
here.

That said, I’m still a bit confused by your earlier comment:

    "That's just part of the standard/first enum."

I’m introducing a new board from a new manufacturer, so I expected to 
add a new enum block — similar to how it's done for other vendor entries 
in the same file. I ran dt_binding_check, and it passed without errors 
for this structure.

Could you clarify which “standard/first enum” you were referring to? 
Should all i.MX8MP-based boards share a single enum block, regardless of 
vendor?

Thanks again for your guidance.

Best regards,
Goran

Krzysztof Kozlowski wrote:
> On Wed, Jun 11, 2025 at 01:30:37PM GMT, Goran Rađenović wrote:
> > Document the Ultratronik Ultra-MACH SBC, based on the NXP i.MX8MP SoC.
> >
> > This board is manufactured by Ultratronik GmbH and uses the compatible
> > string "ux,imx8mp-ultra-mach-sbc".
> >
> > Signed-off-by: Goran Rađenović <goran.radni@xxxxxxxxx>
> > ---
> >   Documentation/devicetree/bindings/arm/fsl.yaml | 6 ++++++
> >   1 file changed, 6 insertions(+)
> >
> > diff --git a/Documentation/devicetree/bindings/arm/fsl.yaml b/Documentation/devicetree/bindings/arm/fsl.yaml
> > index d3b5e6923e41..132a6f39b59a 100644
> > --- a/Documentation/devicetree/bindings/arm/fsl.yaml
> > +++ b/Documentation/devicetree/bindings/arm/fsl.yaml
> > @@ -1232,6 +1232,12 @@ properties:
> >             - const: tq,imx8mp-tqma8mpql            # TQ-Systems GmbH i.MX8MP TQMa8MPQL SOM
> >             - const: fsl,imx8mp
> >   
> > +      - description: Ultratronik SBC i.MX8MP based boards
> > +        items:
> > +          - enum:
>
> Nothing improved... got actually worse, because you never tested it.
>
>    ^
>    |
> Look here. This is '+' means you added it. My previous comment was that
> it should be part of previous enum. If you add enum, then it is not part
> of previous, right?
>
> Best regards,
> Krzysztof