Re: [PATCH 1/2] rust: init: re-enable doctests
From: Benno Lossin
Date: Mon Jun 09 2025 - 15:54:50 EST
On Mon May 26, 2025 at 5:29 PM CEST, Miguel Ojeda wrote:
> Commit a30e94c29673 ("rust: init: make doctests compilable/testable")
> made these tests buildable among others, but eventually the pin-init
> crate was made into its own crate [1] and the tests were marked as
> `ignore` in commit 206dea39e559 ("rust: init: disable doctests").
>
> A few other bits got changed in that reorganization, e.g. the
> `clippy::missing_safety_doc` was removed and the `expect` use.
>
> Since there is no reason not to build/test them, re-enable them.
>
> In order to do so, tweak a few bits to keep the build clean, and also use
> again `expect` since this is one of those places where we can actually
> do so.
>
> Link: https://lore.kernel.org/all/20250308110339.2997091-1-benno.lossin@xxxxxxxxx/ [1]
> Signed-off-by: Miguel Ojeda <ojeda@xxxxxxxxxx>
> ---
> rust/kernel/init.rs | 12 ++++++------
> 1 file changed, 6 insertions(+), 6 deletions(-)
Applied both to pin-init-next -- thanks everyone!
---
Cheers,
Benno