Re: [PATCH v4 06/23] mailbox: Allow controller specific mapping using fwnode

[Andy Shevchenko]

On Mon, Jun 09, 2025 at 02:40:32PM +0530, Anup Patel wrote:
> On Tue, May 27, 2025 at 5:11 PM Andy Shevchenko
> <andriy.shevchenko@xxxxxxxxxxxxxxx> wrote:
> > On Sun, May 25, 2025 at 02:16:53PM +0530, Anup Patel wrote:

...

> > >  struct mbox_chan *mbox_request_channel(struct mbox_client *cl, int index)
> > >  {
> > > +     struct fwnode_reference_args fwspec;
> >
> > + property.h (if not done yet)
> 
> This needs fwnode.h

No, it needs property.h. Please, read the note at the top of fwnode.h why.

...

> > > -     int ret;
> > > +     int i, ret;
> >
> > Why is 'i' signed?
> 
> No particular reason because 'i' is not being assigned a negative
>>  value so both signed and unsigned will work fine.

Besides, splitting will make it easier to check and work on as being less
intrusive change.

-- 
With Best Regards,
Andy Shevchenko