Re: [PATCH net-next v12 00/13] Add support for PSE budget evaluation strategy

[Kory Maincent]

Le Mon, 9 Jun 2025 14:03:46 +0300,
Gal Pressman <gal@xxxxxxxxxx> a écrit :

> On 09/06/2025 11:36, Kory Maincent wrote:
> > Le Sun, 8 Jun 2025 09:17:59 +0300,
> > Gal Pressman <gal@xxxxxxxxxx> a écrit :
> >   
> >> On 28/05/2025 10:31, Paolo Abeni wrote:  
>  [...]  
> >>
> >> Are all new uapi changes expected to come with a test that exercises the
> >> functionality?  
> > 
> > I don't think so and I don't think it is doable for now on PSE. There is
> > nothing that could get the PSE control of a dummy PSE controller driver. We
> > need either the support for a dummy PHY driver similarly to netdevsim or
> > the support for the MDI ports.
> > By luck Maxime Chevallier is currently working on both of these tasks and
> > had already sent several times the patch series for the MDI port support.
> >   
> 
> We shouldn't rule it out so quickly, testing is important, let's try to
> accommodate to our rules.
> 
> Why can't this be tested on real hardware using a drivers/net/hw
> selftest? The test can skip if it lacks the needed hardware.
> Or rebase this over Maxime's work?

How should I do it if I need to use ethtool to test it? It is a vicious circle
as ethtool need this to be merge before supporting it.
Would it be ok to accept it like that and wait for ethtool support to add the
selftest?
Otherwise I could test it through ynl python command but there is no similar
cases in the selftest.

Nevertheless, it would have been nicer to point this out earlier in the series.

Regards,
-- 
Köry Maincent, Bootlin
Embedded Linux and kernel engineering
https://bootlin.com