Re: [PATCH net-next v12 00/13] Add support for PSE budget evaluation strategy
From: Gal Pressman
Date: Mon Jun 09 2025 - 07:04:12 EST
On 09/06/2025 11:36, Kory Maincent wrote:
> Le Sun, 8 Jun 2025 09:17:59 +0300,
> Gal Pressman <gal@xxxxxxxxxx> a écrit :
>
>> On 28/05/2025 10:31, Paolo Abeni wrote:
>>> I'm sorry, even if this has been posted (just) before the merge window,
>>> I think an uAPI extension this late is a bit too dangerous, please
>>> repost when net-next will reopen after the merge window.
>>
>> Are all new uapi changes expected to come with a test that exercises the
>> functionality?
>
> I don't think so and I don't think it is doable for now on PSE. There is nothing
> that could get the PSE control of a dummy PSE controller driver. We need either
> the support for a dummy PHY driver similarly to netdevsim or the support for the
> MDI ports.
> By luck Maxime Chevallier is currently working on both of these tasks and had
> already sent several times the patch series for the MDI port support.
>
We shouldn't rule it out so quickly, testing is important, let's try to
accommodate to our rules.
Why can't this be tested on real hardware using a drivers/net/hw
selftest? The test can skip if it lacks the needed hardware.
Or rebase this over Maxime's work?