Re: [PATCH] ASoC: amd: acp: Fix pointer assignments for snd_soc_acpi_mach structures

From: Mark Brown
Date: Mon Jun 09 2025 - 08:16:33 EST


On Mon, Jun 09, 2025 at 05:42:32PM +0530, Venkata Prasad Potturu wrote:
> This patch modifies the assignment of machine structure pointers in the
> acp_pci_probe function. Previously, the machine pointers were assigned
> using the address-of operator (&), which caused incompatibility issues
> in type assignments.
>
> Additionally, the declarations of the machine arrays in amd.h have been
> updated to reflect that they are indeed arrays (`[]`). The code is
> further cleaned up by declaring the codec structures in
> amd-acpi-mach.c as static, reflecting their intended usage.
>
> error: symbol 'amp_rt1019' was not declared. Should it be static?
> error: symbol 'amp_max' was not declared. Should it be static?

It's fine this time but these staticisiations should have been a
separate commit since there's no overlap.

Attachment: signature.asc
Description: PGP signature