Re: [PATCH 2/5] VFS: Minor fixes for porting.rst

From: Jeff Layton
Date: Mon Jun 09 2025 - 08:14:32 EST


On Mon, 2025-06-09 at 09:09 +1000, NeilBrown wrote:
> This paragraph was relevant for an earlier version of the code which
> passed the qstr as a struct instead of a point. The version that landed
> passed the pointer in all cases so this para is now pointless.
>
> Signed-off-by: NeilBrown <neil@xxxxxxxxxx>
> ---
> Documentation/filesystems/porting.rst | 3 ---
> 1 file changed, 3 deletions(-)
>
> diff --git a/Documentation/filesystems/porting.rst b/Documentation/filesystems/porting.rst
> index 3616d7161dab..e8c9f21582d1 100644
> --- a/Documentation/filesystems/porting.rst
> +++ b/Documentation/filesystems/porting.rst
> @@ -1224,9 +1224,6 @@ lookup_noperm_unlocked(), lookup_noperm_positive_unlocked(). They now
> take a qstr instead of separate name and length. QSTR() can be used
> when strlen() is needed for the length.
>
> -For try_lookup_noperm() a reference to the qstr is passed in case the
> -hash might subsequently be needed.
> -
> These function no longer do any permission checking - they previously
> checked that the caller has 'X' permission on the parent. They must
> ONLY be used internally by a filesystem on itself when it knows that

Reviewed-by: Jeff Layton <jlayton@xxxxxxxxxx>